280b2ff856
* Initial plan * Add GPIO_NUM_NC guards for LampController and SingleLed across all board files Boards crash when LAMP_GPIO or BUILTIN_LED_GPIO is set to GPIO_NUM_NC because LampController and SingleLed are instantiated unconditionally. Fix: Guard LampController with `if (LAMP_GPIO != GPIO_NUM_NC)` in InitializeTools() and guard SingleLed with `if (BUILTIN_LED_GPIO != GPIO_NUM_NC)` in GetLed(), falling back to NoLed when GPIO is not connected. Fixes the reported crash on bread-compact-wifi-lcd and hardens all similar boards. Co-authored-by: 78 <4488133+78@users.noreply.github.com> * Fix crash when LAMP_GPIO or BUILTIN_LED_GPIO is GPIO_NUM_NC (minimal 2-file fix) Instead of adding guards in every board file (36 files), fix the root cause in just 2 source files: 1. SingleLed constructor: replace assert(gpio != GPIO_NUM_NC) with graceful early return, leaving led_strip_ as nullptr (all methods already null-check it) 2. LampController constructor: add early return when gpio_num == GPIO_NUM_NC This fixes the crash on bread-compact-wifi-lcd and any other board where these GPIOs are set to GPIO_NUM_NC. Co-authored-by: 78 <4488133+78@users.noreply.github.com> * Remove esp_timer_delete from destructor to match original behavior Co-authored-by: 78 <4488133+78@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: 78 <4488133+78@users.noreply.github.com>
49 lines
1.5 KiB
C++
49 lines
1.5 KiB
C++
#ifndef __LAMP_CONTROLLER_H__
|
|
#define __LAMP_CONTROLLER_H__
|
|
|
|
#include "mcp_server.h"
|
|
|
|
|
|
class LampController {
|
|
private:
|
|
bool power_ = false;
|
|
gpio_num_t gpio_num_;
|
|
|
|
public:
|
|
LampController(gpio_num_t gpio_num) : gpio_num_(gpio_num) {
|
|
if (gpio_num_ == GPIO_NUM_NC) {
|
|
return;
|
|
}
|
|
|
|
gpio_config_t config = {
|
|
.pin_bit_mask = (1ULL << gpio_num_),
|
|
.mode = GPIO_MODE_OUTPUT,
|
|
.pull_up_en = GPIO_PULLUP_DISABLE,
|
|
.pull_down_en = GPIO_PULLDOWN_DISABLE,
|
|
.intr_type = GPIO_INTR_DISABLE,
|
|
};
|
|
ESP_ERROR_CHECK(gpio_config(&config));
|
|
gpio_set_level(gpio_num_, 0);
|
|
|
|
auto& mcp_server = McpServer::GetInstance();
|
|
mcp_server.AddTool("self.lamp.get_state", "Get the power state of the lamp", PropertyList(), [this](const PropertyList& properties) -> ReturnValue {
|
|
return power_ ? "{\"power\": true}" : "{\"power\": false}";
|
|
});
|
|
|
|
mcp_server.AddTool("self.lamp.turn_on", "Turn on the lamp", PropertyList(), [this](const PropertyList& properties) -> ReturnValue {
|
|
power_ = true;
|
|
gpio_set_level(gpio_num_, 1);
|
|
return true;
|
|
});
|
|
|
|
mcp_server.AddTool("self.lamp.turn_off", "Turn off the lamp", PropertyList(), [this](const PropertyList& properties) -> ReturnValue {
|
|
power_ = false;
|
|
gpio_set_level(gpio_num_, 0);
|
|
return true;
|
|
});
|
|
}
|
|
};
|
|
|
|
|
|
#endif // __LAMP_CONTROLLER_H__
|