chore: update external connector deployment flow

app-instance/create-instance.sh

@@ -22,6 +22,7 @@ USER_FILES_MAX_UPLOAD_BYTES="${USER_FILES_MAX_UPLOAD_BYTES:-}"
 EXTERNAL_CONNECTOR_BASE_URL="${EXTERNAL_CONNECTOR_BASE_URL:-http://external-connector:8787}"
 EXTERNAL_CONNECTOR_TOKEN="${EXTERNAL_CONNECTOR_TOKEN:-}"
 BEAVER_BRIDGE_TOKEN="${BEAVER_BRIDGE_TOKEN:-}"
+EXTERNAL_CONNECTOR_CALLBACK_BASE_URL="${EXTERNAL_CONNECTOR_CALLBACK_BASE_URL:-}"
 BACKEND_ID=""
 CLIENT_ID=""
 CLIENT_SECRET=""
@@ -81,6 +82,9 @@ Optional:
                               External connector sidecar URL. Default: http://external-connector:8787
   --external-connector-token <token>
                               Service token used for Beaver-to-sidecar requests.
+  --external-connector-callback-base-url <url>
+                              Internal URL the sidecar should call back for inbound events.
+                              Default: http://<container-name>:8080 when a Docker network is used.
   --bridge-token <token>      Service token accepted from the connector bridge.
   --backend-id <id>           Pre-assigned backend id.
   --client-id <id>            Pre-assigned AuthZ client id.
@@ -565,6 +569,10 @@ while [[ $# -gt 0 ]]; do
       EXTERNAL_CONNECTOR_TOKEN="${2:-}"
       shift 2
       ;;
+    --external-connector-callback-base-url)
+      EXTERNAL_CONNECTOR_CALLBACK_BASE_URL="${2:-}"
+      shift 2
+      ;;
     --bridge-token)
       BEAVER_BRIDGE_TOKEN="${2:-}"
       shift 2
@@ -772,6 +780,10 @@ RUN_ARGS=(
   --label "beaver.instance.public_url=${PUBLIC_URL}"
 )
 
+if [[ -z "$EXTERNAL_CONNECTOR_CALLBACK_BASE_URL" && -n "$NETWORK_NAME" ]]; then
+  EXTERNAL_CONNECTOR_CALLBACK_BASE_URL="http://${CONTAINER_NAME}:8080"
+fi
+
 if [[ "$SEED_INITIAL_SKILLS" -eq 1 && -n "$INITIAL_SKILLS_DIR" ]]; then
   RUN_ARGS+=(
     -v "${INITIAL_SKILLS_DIR}:/opt/app/initial-skills:ro"
@@ -786,6 +798,9 @@ fi
 if [[ -n "$EXTERNAL_CONNECTOR_TOKEN" ]]; then
   RUN_ARGS+=(-e "EXTERNAL_CONNECTOR_TOKEN=${EXTERNAL_CONNECTOR_TOKEN}")
 fi
+if [[ -n "$EXTERNAL_CONNECTOR_CALLBACK_BASE_URL" ]]; then
+  RUN_ARGS+=(-e "EXTERNAL_CONNECTOR_CALLBACK_BASE_URL=${EXTERNAL_CONNECTOR_CALLBACK_BASE_URL}")
+fi
 if [[ -n "$BEAVER_BRIDGE_TOKEN" ]]; then
   RUN_ARGS+=(-e "BEAVER_BRIDGE_TOKEN=${BEAVER_BRIDGE_TOKEN}")
 fi